cmb 0 Posted August 30, 2013 Share Posted August 30, 2013 I'm using Energia with a Launchpad (LM4F120XL), and I've found some strange behavior when using a timer interrupt. When the interrupt setup code is compiled in, functions that do string processing (atoi, strtoul, strtok, etc.) do not return the expected value.In the code below, atoi() will return 0 when given the input "12". Note that the timer interrupt hasn't even been set up at the point where atoi() is called. In particular, it's the call to IntRegister() that causes the problem. The same code will work as expected if IntRegister() is commented out.Also note that everything works fine if an infinite loop is placed immediately before the initTimer() call -- in that case, I'm guessing the compiler is optimizing out everything in initTimer() because it's unreachable.strcmp() was also misbehaving (i.e. returning nonzero values for identical strings), but when I moved the const char* comparison string from global scope to function-level scope, the comparison began working as expected.Anyone have any ideas about this? It seems like it might have something to do with the arrangement of symbols in memory. --Colin #include "inc/hw_ints.h" #include "driverlib/sysctl.h" #include "driverlib/interrupt.h" #include "driverlib/timer.h" void timer0_handler(void) { TimerIntClear(TIMER0_BASE, TIMER_TIMA_TIMEOUT); } void initTimer(unsigned Hz) { SysCtlPeripheralEnable(SYSCTL_PERIPH_TIMER0); TimerConfigure(TIMER0_BASE, TIMER_CFG_32_BIT_PER); unsigned long ulPeriod = (SysCtlClockGet() / Hz) / 2; TimerLoadSet(TIMER0_BASE, TIMER_A, ulPeriod - 1); IntEnable(INT_TIMER0A); IntRegister(INT_TIMER0A, timer0_handler); TimerIntEnable(TIMER0_BASE, TIMER_TIMA_TIMEOUT); IntMasterEnable(); TimerEnable(TIMER0_BASE, TIMER_A); } void setup() { IntMasterDisable(); Serial.begin(9600); } void loop() { const char *dbuf = "12"; Serial.println(atoi(dbuf)); initTimer(3); while (1); } Thorvard 1 Quote Link to post Share on other sites
szymekrak1426459900 0 Posted August 30, 2013 Share Posted August 30, 2013 I see that my code for timer differs. This is how I enable my timer for fatfs library: ROM_SysCtlPeripheralEnable(SYSCTL_PERIPH_TIMER0); ROM_TimerConfigure(TIMER0_BASE, TIMER_CFG_PERIODIC); TimerIntRegister(TIMER0_BASE,TIMER_A,FatInt); ROM_TimerLoadSet(TIMER0_BASE, TIMER_A, (SysCtlClockGet() / 100 )-1); ROM_IntEnable(INT_TIMER0A); ROM_TimerIntEnable(TIMER0_BASE, TIMER_TIMA_TIMEOUT); ROM_TimerEnable(TIMER0_BASE, TIMER_A); FatInt is the name of my timer function. My code uses string functions and they work. I don't have IntMasterDisable nor IntMasterEnable anywhere. Quote Link to post Share on other sites
monpetit 0 Posted September 1, 2013 Share Posted September 1, 2013 I could solve this problem (misbehaving atoi(), strcmp() ...) with changing compiler. I changed lm4f tools from yagarto to gcc-arm (https://launchpad.net/gcc-arm-embedded). If you use Windows, you can also use atmel's arm compiler in atmel studio 6. Quote Link to post Share on other sites
cmb 0 Posted September 1, 2013 Author Share Posted September 1, 2013 It seems like this is probably a compiler (or framework) bug. Switching to the ROM_ functions for timer interrupt setup did not have any effect. I haven't tried a different compiler/environment, but I would definitely like to continue using Energia if anyone could find a workaround for this problem. The code below is sufficient to reproduce the problem (using Energia 0101E0009, running on Windows XP 32-bit). #include "driverlib/timer.h" void timer_isr(void) { TimerIntClear(TIMER0_BASE, TIMER_TIMA_TIMEOUT); } void setup() { Serial.begin(9600); } void loop() { const char *dbuf = "12"; Serial.println("-----"); Serial.println(atoi(dbuf)); // this will print '0' instead of '12' Serial.println("-----"); // removing the following line causes atoi() to work normally TimerIntRegister(TIMER0_BASE, TIMER_A, timer_isr); while (1); } Quote Link to post Share on other sites
cmb 0 Posted September 1, 2013 Author Share Posted September 1, 2013 I've confirmed that this is a problem somewhere in the toolchain or C library that is packaged with Energia 0101E0009. As I said, I'm developing on Windows XP 32-bit, although I don't know if the problem is specific to this development platform. I downloaded the GNU embedded ARM package 4.7.4 (from the Launchpad site: https://launchpad.net/gcc-arm-embedded) and replaced these files/directories in the Energia directory structure with the equivalents from the GNU package: energia-0101E0009/hardware/tools/lm4f/arm-none-eabi/ energia-0101E0009/hardware/tools/lm4f/bin/*.exe Note: the Energia bin/ directory contains two files not in the GNU package: arm-none-eabi-run.exe, and lm4flash.exe. I kept both of these. Also note that the GCC binary is version 4.7.4 rather than 4.7.1, so that executable name is different. I also copied this library directory from the GNU package... 4.7 2013q2/lib/gcc/arm-none-eabi/4.7.4 ...and put it in two different locations in the Energia tree: energia-0101E0009/hardware/tools/lm4f/lib/gcc/arm-none-eabi/4.7.4 energia-0101E0009/hardware/tools/lm4f/libexec/gcc/arm-none-eabi/4.7.4 After doing this, I rebuilt the code that I posted above, and atoi() was working properly. I also added some LED-blinking content to the timer ISR, and a call to strcmp(), and everything was working as expected. I've only recently started using Energia, so I'm not sure if what I have here constitutes enough for a bug report. Please let me know if I should provide any more information. --Colin Thorvard 1 Quote Link to post Share on other sites
Bernard 7 Posted September 1, 2013 Share Posted September 1, 2013 Hello, I have got same problems using TimerIntRegister ( strange behavior) I use another way for interrupts Ino file /** * LM4F120 - timer based **/ #include "timer_0.h" #include "driverlib/sysctl.h" volatile int8_t isrFlag; void setup(){ noInterrupts(); Serial.begin(9600); pinMode(RED_LED, OUTPUT); interrupts(); initTimer(10); } //********************************************************************* void loop() { const char *dbuf = "12"; if ( isrFlag == 1 ) { noInterrupts(); isrFlag = 0 ; Serial.println(atoi(dbuf)); interrupts(); } } //*********************************************************************** timer_0.h #ifdef __cplusplus extern "C" { #endif void initTimer(unsigned f); void Timer0IntHandler(void); #ifdef __cplusplus } #endif timer_0.c /* * timer_0.c */ #include "Energia.h" #include "inc/hw_ints.h" #include "driverlib/interrupt.h" #include "driverlib/sysctl.h" #include "driverlib/timer.h" #include "timer_0.h" extern volatile int8_t isrFlag; void initTimer(unsigned f) { unsigned long ulPeriod = (SysCtlClockGet() / f) / 2; ROM_SysCtlPeripheralEnable(SYSCTL_PERIPH_TIMER0); ROM_TimerConfigure(TIMER0_BASE, TIMER_CFG_PERIODIC); ROM_TimerLoadSet(TIMER0_BASE, TIMER_A, ulPeriod -1); ROM_IntEnable(INT_TIMER0A); ROM_TimerIntEnable(TIMER0_BASE, TIMER_TIMA_TIMEOUT); ROM_TimerEnable(TIMER0_BASE, TIMER_A); } void Timer0IntHandler() { // Clear the timer interrupt ROM_TimerIntClear(TIMER0_BASE, TIMER_TIMA_TIMEOUT); digitalWrite(RED_LED, digitalRead(RED_LED) ^ 1);// toggle LED pin isrFlag =1; } startup_gcc.c //***************************************************************************** // // startup_gcc.c - Startup code for use with GNU tools. // // Copyright (c) 2009-2012 Texas Instruments Incorporated. All rights reserved. // Software License Agreement // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // Redistributions of source code must retain the above copyright // notice, this list of conditions and the following disclaimer. // // Redistributions in binary form must reproduce the above copyright // notice, this list of conditions and the following disclaimer in the // documentation and/or other materials provided with the // distribution. // // Neither the name of Texas Instruments Incorporated nor the names of // its contributors may be used to endorse or promote products derived // from this software without specific prior written permission. // // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // //***************************************************************************** #include "Energia.h" #include "inc/hw_types.h" #include "inc/hw_nvic.h" //***************************************************************************** // // Forward declaration of the default fault handlers. // //***************************************************************************** void ResetISR(void); static void NmiSR(void); static void FaultISR(void); static void IntDefaultHandler(void); //***************************************************************************** // // The entry point for the application. // //***************************************************************************** extern int main(void); extern void GPIOAIntHandler(void); extern void GPIOBIntHandler(void); extern void GPIOCIntHandler(void); extern void GPIODIntHandler(void); extern void GPIOEIntHandler(void); extern void GPIOFIntHandler(void); /* * create some overridable default signal handlers */ __attribute__((weak)) void UARTIntHandler(void) {} __attribute__((weak)) void ToneIntHandler(void) {} __attribute__((weak)) void I2CIntHandler(void) {} __attribute__((weak)) extern void Timer0IntHandler(void) {} __attribute__((weak)) extern void ADC0IntHandler(void) {} //***************************************************************************** // System stack start determined by ldscript, normally highest ram address //***************************************************************************** extern unsigned _estack; //***************************************************************************** // // The vector table. Note that the proper constructs must be placed on this to // ensure that it ends up at physical address 0x0000.0000. // //***************************************************************************** __attribute__ ((section(".isr_vector"))) void (* const g_pfnVectors[])(void) = { (void *)&_estack, // The initial stack pointer, 0x20008000 32K ResetISR, // The reset handler NmiSR, // The NMI handler FaultISR, // The hard fault handler IntDefaultHandler, // The MPU fault handler IntDefaultHandler, // The bus fault handler IntDefaultHandler, // The usage fault handler 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved IntDefaultHandler, // SVCall handler IntDefaultHandler, // Debug monitor handler 0, // Reserved IntDefaultHandler, // The PendSV handler IntDefaultHandler, // The SysTick handler GPIOAIntHandler, // GPIO Port A GPIOBIntHandler, // GPIO Port B GPIOCIntHandler, // GPIO Port C GPIODIntHandler, // GPIO Port D GPIOEIntHandler, // GPIO Port E UARTIntHandler, // UART0 Rx and Tx UARTIntHandler, // UART1 Rx and Tx IntDefaultHandler, // SSI0 Rx and Tx I2CIntHandler, // I2C0 Master and Slave IntDefaultHandler, // PWM Fault IntDefaultHandler, // PWM Generator 0 IntDefaultHandler, // PWM Generator 1 IntDefaultHandler, // PWM Generator 2 IntDefaultHandler, // Quadrature Encoder 0 IntDefaultHandler, // ADC Sequence 0 IntDefaultHandler, // ADC Sequence 1 IntDefaultHandler, // ADC Sequence 2 ADC0IntHandler, // ADC Sequence 3 IntDefaultHandler, // Watchdog timer Timer0IntHandler, // Timer 0 subtimer A IntDefaultHandler, // Timer 0 subtimer B IntDefaultHandler, // Timer 1 subtimer A IntDefaultHandler, // Timer 1 subtimer B IntDefaultHandler, // Timer 2 subtimer A IntDefaultHandler, // Timer 2 subtimer B IntDefaultHandler, // Analog Comparator 0 IntDefaultHandler, // Analog Comparator 1 IntDefaultHandler, // Analog Comparator 2 IntDefaultHandler, // System Control (PLL, OSC, BO) IntDefaultHandler, // FLASH Control GPIOFIntHandler, // GPIO Port F IntDefaultHandler, // GPIO Port G IntDefaultHandler, // GPIO Port H UARTIntHandler, // UART2 Rx and Tx IntDefaultHandler, // SSI1 Rx and Tx IntDefaultHandler, // Timer 3 subtimer A IntDefaultHandler, // Timer 3 subtimer B I2CIntHandler, // I2C1 Master and Slave IntDefaultHandler, // Quadrature Encoder 1 IntDefaultHandler, // CAN0 IntDefaultHandler, // CAN1 IntDefaultHandler, // CAN2 IntDefaultHandler, // Ethernet IntDefaultHandler, // Hibernate IntDefaultHandler, // USB0 IntDefaultHandler, // PWM Generator 3 IntDefaultHandler, // uDMA Software Transfer IntDefaultHandler, // uDMA Error IntDefaultHandler, // ADC1 Sequence 0 IntDefaultHandler, // ADC1 Sequence 1 IntDefaultHandler, // ADC1 Sequence 2 IntDefaultHandler, // ADC1 Sequence 3 IntDefaultHandler, // I2S0 IntDefaultHandler, // External Bus Interface 0 IntDefaultHandler, // GPIO Port J IntDefaultHandler, // GPIO Port K IntDefaultHandler, // GPIO Port L IntDefaultHandler, // SSI2 Rx and Tx IntDefaultHandler, // SSI3 Rx and Tx UARTIntHandler, // UART3 Rx and Tx UARTIntHandler, // UART4 Rx and Tx UARTIntHandler, // UART5 Rx and Tx UARTIntHandler, // UART6 Rx and Tx UARTIntHandler, // UART7 Rx and Tx 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved I2CIntHandler, // I2C2 Master and Slave I2CIntHandler, // I2C3 Master and Slave ToneIntHandler, // Timer 4 subtimer A IntDefaultHandler, // Timer 4 subtimer B 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved 0, // Reserved IntDefaultHandler, // Timer 5 subtimer A IntDefaultHandler, // Timer 5 subtimer B IntDefaultHandler, // Wide Timer 0 subtimer A IntDefaultHandler, // Wide Timer 0 subtimer B IntDefaultHandler, // Wide Timer 1 subtimer A IntDefaultHandler, // Wide Timer 1 subtimer B IntDefaultHandler, // Wide Timer 2 subtimer A IntDefaultHandler, // Wide Timer 2 subtimer B IntDefaultHandler, // Wide Timer 3 subtimer A IntDefaultHandler, // Wide Timer 3 subtimer B IntDefaultHandler, // Wide Timer 4 subtimer A IntDefaultHandler, // Wide Timer 4 subtimer B IntDefaultHandler, // Wide Timer 5 subtimer A IntDefaultHandler, // Wide Timer 5 subtimer B IntDefaultHandler, // FPU IntDefaultHandler, // PECI 0 IntDefaultHandler, // LPC 0 IntDefaultHandler, // I2C4 Master and Slave IntDefaultHandler, // I2C5 Master and Slave IntDefaultHandler, // GPIO Port M IntDefaultHandler, // GPIO Port N IntDefaultHandler, // Quadrature Encoder 2 IntDefaultHandler, // Fan 0 0, // Reserved IntDefaultHandler, // GPIO Port P (Summary or P0) IntDefaultHandler, // GPIO Port P1 IntDefaultHandler, // GPIO Port P2 IntDefaultHandler, // GPIO Port P3 IntDefaultHandler, // GPIO Port P4 IntDefaultHandler, // GPIO Port P5 IntDefaultHandler, // GPIO Port P6 IntDefaultHandler, // GPIO Port P7 IntDefaultHandler, // GPIO Port Q (Summary or Q0) IntDefaultHandler, // GPIO Port Q1 IntDefaultHandler, // GPIO Port Q2 IntDefaultHandler, // GPIO Port Q3 IntDefaultHandler, // GPIO Port Q4 IntDefaultHandler, // GPIO Port Q5 IntDefaultHandler, // GPIO Port Q6 IntDefaultHandler, // GPIO Port Q7 IntDefaultHandler, // GPIO Port R IntDefaultHandler, // GPIO Port S IntDefaultHandler, // PWM 1 Generator 0 IntDefaultHandler, // PWM 1 Generator 1 IntDefaultHandler, // PWM 1 Generator 2 IntDefaultHandler, // PWM 1 Generator 3 IntDefaultHandler // PWM 1 Fault }; //***************************************************************************** // // The following are constructs created by the linker, indicating where the // the "data" and "bss" segments reside in memory. The initializers for the // for the "data" segment resides immediately following the "text" segment. // //***************************************************************************** extern unsigned long _etext; extern unsigned long _data; extern unsigned long _edata; extern unsigned long _bss; extern unsigned long _ebss; extern void (*__preinit_array_start[])(void); extern void (*__preinit_array_end[])(void); extern void (*__init_array_start[])(void); extern void (*__init_array_end[])(void); //***************************************************************************** // // This is the code that gets called when the processor first starts execution // following a reset event. Only the absolutely necessary set is performed, // after which the application supplied entry() routine is called. Any fancy // actions (such as making decisions based on the reset cause register, and // resetting the bits in that register) are left solely in the hands of the // application. // //***************************************************************************** void ResetISR(void) { unsigned long *pulSrc, *pulDest; unsigned i, cnt; // // Copy the data segment initializers from flash to SRAM. // pulSrc = &_etext; for (pulDest = &_data; pulDest < &_edata;) { *pulDest++ = *pulSrc++; } // // Zero fill the bss segment. // __asm( " ldr r0, =_bss\n" " ldr r1, =_ebss\n" " mov r2, #0\n" " .thumb_func\n" "1:\n" " cmp r0, r1\n" " it lt\n" " strlt r2, [r0], #4\n" " blt 1b" ); (void)_bss; (void)_ebss; // get rid of unused warnings // // Enable the floating-point unit before calling c++ ctors // HWREG(NVIC_CPAC) = ((HWREG(NVIC_CPAC) & ~(NVIC_CPAC_CP10_M | NVIC_CPAC_CP11_M)) | NVIC_CPAC_CP10_FULL | NVIC_CPAC_CP11_FULL); // // call any global c++ ctors // cnt = __preinit_array_end - __preinit_array_start; for (i = 0; i < cnt; i++) __preinit_array_start[i](); cnt = __init_array_end - __init_array_start; for (i = 0; i < cnt; i++) __init_array_start[i](); // // call 'C' entry point, Energia never returns from main // main(); } void *__dso_handle = 0; /** * _sbrk - newlib memory allocation routine */ typedef char *caddr_t; caddr_t _sbrk (int incr) { double current_sp; extern char end asm ("end"); /* Defined by linker */ static char * heap_end; char * prev_heap_end; if (heap_end == NULL) { heap_end = &end; /* first ram address after bss and data */ } prev_heap_end = heap_end; // simplistic approach to prevent the heap from corrupting the stack // TBD: review for alternatives if ( heap_end + incr < (caddr_t)¤t_sp ) { heap_end += incr; return (caddr_t) prev_heap_end; } else { return NULL; } } //***************************************************************************** // // This is the code that gets called when the processor receives a NMI. This // simply enters an infinite loop, preserving the system state for examination // by a debugger. // //***************************************************************************** static void NmiSR(void) { // // Enter an infinite loop. // while (1) { ; // trap NMI } } //***************************************************************************** // // This is the code that gets called when the processor receives a fault // interrupt. This simply enters an infinite loop, preserving the system state // for examination by a debugger. // //***************************************************************************** static void FaultISR(void) { // // Enter an infinite loop. // while (1) { ; // trap FAULT } } //***************************************************************************** // // This is the code that gets called when the processor receives an unexpected // interrupt. This simply enters an infinite loop, preserving the system state // for examination by a debugger. // //***************************************************************************** static void IntDefaultHandler(void) { // // Go into an infinite loop. // while (1) { ; // trap any handler not defined } } Tested on Windows 7 and Ubuntu 12.04 LTS I can see 12 regards Bernard Quote Link to post Share on other sites
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.